-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(completions): imports, aliases, module attributes #410
Merged
Commits on Apr 11, 2024
-
feat(completions): imports, aliases, module attributes
This patch adds support for completion candidates for functions/macros imported via `import`, modules aliases via `alias`, module attributes, and any of the above when injected via a macro such as `use`. However, this is powered by new APIs and compiler changs that will be available in Elixir 1.17, so when completions are enabled, we will use a bundled 1.17 runtime of Elixir, instead of the ELixir in the user's path. This is a tradeoff, but I think one that is worthwhile in the name of progress and improving the language and ecosystem. Once completions exit experimental status, this means that Next LS will always run with a bundled copy of Elixir of Elixir unless the user's local copy is sufficiently new. This can be controlled via a setting.
Configuration menu - View commit details
-
Copy full SHA for 9f50457 - Browse repository at this point
Copy the full SHA 9f50457View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c8a63e - Browse repository at this point
Copy the full SHA 1c8a63eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf05598 - Browse repository at this point
Copy the full SHA cf05598View commit details -
Configuration menu - View commit details
-
Copy full SHA for a71248f - Browse repository at this point
Copy the full SHA a71248fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5221e21 - Browse repository at this point
Copy the full SHA 5221e21View commit details
Commits on Apr 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6db8fb9 - Browse repository at this point
Copy the full SHA 6db8fb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 689b5e9 - Browse repository at this point
Copy the full SHA 689b5e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff3b5e6 - Browse repository at this point
Copy the full SHA ff3b5e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8adb76 - Browse repository at this point
Copy the full SHA e8adb76View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.