test: refactor tests using didOpen notification #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a macro to hide the miscellaneous setup for the document didOpen notification.
mhanberg
reviewed
Nov 14, 2023
mhanberg
reviewed
Nov 14, 2023
test/support/utils.ex
Outdated
| end | ||
|
|
||
| defmacro did_open(client, file_path) do | ||
| did_open(client, file_path, File.read!(file_path)) |
There was a problem hiding this comment.
It's not clear to me if reading the file at compile time will work as the files are written to disk when the test is running
There was a problem hiding this comment.
Yes you're correct but I think I can fix it in the other PR and remove it for now, I will probably just inline the whole other macro and call File.read!(unquote(file_path)). I hadn't tested it here since the existing tests that use it just use text instead of real files.
NJichev
changed the title
mhanberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a macro to hide the miscellaneous setup for the document didOpen notification.