Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension,credo): ability to disable Credo extension #321

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

mhanberg
Copy link
Collaborator

@mhanberg mhanberg commented Nov 2, 2023

No description provided.

@mhanberg
Copy link
Collaborator Author

mhanberg commented Nov 2, 2023

@mhanberg mhanberg merged commit 6fda39e into main Nov 2, 2023
5 checks passed
@mhanberg mhanberg deleted the 2023-11-01-disable-credo-extension branch November 2, 2023 01:05
@tensiondriven
Copy link

@mhanberg ^

@mhanberg
Copy link
Collaborator Author

mhanberg commented Nov 6, 2023

@tensiondriven can you clarify the ping?

@tensiondriven
Copy link

Oops, I must have commented on the wrong PR. Here's my original comment:

#323 (comment)

And a breakdown of my concern:

  1. I'm running elixir-ls via vscode from the Marketplace which is showing v0.11.0
  2. To work around issues with credo, I have to manually edit my .credo.exs which is in source control, meaning I have to keep a dirty file around.
  3. The ability to configure credo has been fixed and merged into next-ls (thank you 💯 )
  4. A release appears to be built for next-ls, but the vscode repo hasn't been updated (not sure if this is a problem)
  5. I don't know how to build both elixir-ls and the vscode extension locally such that I can run the code which has the CLI option fix for credo.

So, I'm looking for some guidance - Should I:

  1. Wait for the vscode package to be updated/published and update from within vscode
  2. Patch my local vscode extension with a build of next-ls from the releases in this repo (if so, does the vscode extension need additional config?)
  3. Build local versions of next-ls and the vscode extension? (if so, what configuration is required?)

Sorry if this comes off as ignorant or low-effort. I'm really not sure how the vscode extension interacts with next-ls and could use some guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants