-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: completions #289
Merged
Merged
feat: completions #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
mhanberg
commented
Oct 17, 2023
lib/next_ls/db.ex
Outdated
Comment on lines
198
to
203
sqlite3 error: #{message} | ||
|
||
statement: #{statement} | ||
arguments: #{inspect(args)} | ||
┌───────────── | ||
│sqlite3 error: #{message} | ||
│ | ||
│statement: #{statement} | ||
│arguments: #{inspect(args)} | ||
└───────────── |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
mhanberg
commented
Oct 17, 2023
@@ -29,6 +29,18 @@ defmodule NextLS.ASTHelpers.Variables do | |||
end | |||
end | |||
|
|||
def collect(ast) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment out
mhanberg
force-pushed
the
2023-09-15-completions
branch
from
October 17, 2023 20:52
407e355
to
bc8217d
Compare
mhanberg
force-pushed
the
2023-09-15-completions
branch
from
October 19, 2023 01:11
c95eb2f
to
9f39fc9
Compare
1 task
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements basic autocompletion.
Current completion candidates supported
More features, particularly features that rely on contextual information about the code itself (meaning, which identifiers, aliases, imports are available) will come in subsequent patches.
Partially addresses #45
Experimental
This patch also introduces a new initialization option,
experimental
.This feature will be gated as an experimental feature as it's built out. The purpose of this is so that early-early adopters can try it out and report bugs, but folks who would rather wait for something more stable won't have it affect their workflows.
To enable this feature, toggle the completions experiment in your editor.
Nvim (elixir-tools.nvim)
Visual Studio Code (elixir-tools.vscode)
Other editors
Not sure 😅
Demos
TODO: record them my guy
TODO
Acknowedgements
This feature is initially based on
IEx.Autocomplete
. Huge thanks to the Elixir core team's efforts to help kickstart this feature. More deviations will likely occur as we gain more contextual parsing for things like imports, aliases and variables.