Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: local variables #253

Merged
merged 4 commits into from
Oct 2, 2023
Merged

feat: local variables #253

merged 4 commits into from
Oct 2, 2023

Conversation

biletskyy
Copy link
Contributor

@biletskyy biletskyy commented Oct 1, 2023 •
edited
Loading

resolves #85

Add ability to go to local variable definition and references.

Correctly processes variables in 'cond' and defined with 'destructure'

@biletskyy
Copy link
Contributor Author

Here is preview

local_variables1.mp4

@biletskyy biletskyy marked this pull request as ready for review October 1, 2023 11:30
mhanberg
mhanberg reviewed Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@mhanberg mhanberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick scan from my phone. Will need to look again later from the computer.

lib/next_ls/helpers/ast_helpers.ex Outdated Show resolved Hide resolved
test/next_ls/helpers/ast_helpers_variables_test.exs Outdated Show resolved Hide resolved
test/next_ls/helpers/ast_helpers_variables_test.exs Outdated Show resolved Hide resolved
test/next_ls/helpers/ast_helpers_variables_test.exs Outdated Show resolved Hide resolved
lib/next_ls/helpers/ast_helpers.ex Outdated Show resolved Hide resolved
@mhanberg
Copy link
Collaborator

mhanberg commented Oct 2, 2023

After we merge this, can you create tracking issues for the remaining TODOs?

@mhanberg mhanberg enabled auto-merge (squash) October 2, 2023 01:05
@mhanberg mhanberg disabled auto-merge October 2, 2023 01:06
@mhanberg mhanberg enabled auto-merge (squash) October 2, 2023 01:06
@mhanberg mhanberg merged commit 7099370 into elixir-tools:main Oct 2, 2023
3 checks passed
This was referenced Oct 2, 2023
Merged
Closed
Closed
Merged
Merged
Merged
@biletskyy
Copy link
Contributor Author

After we merge this, can you create tracking issues for the remaining TODOs?

Yes, I created issues #261 and #262. First one is probably liked to issue Can't find references of the contents of an inline function #184, as you mentioned before.

@github-actions github-actions bot mentioned this pull request Jan 18, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Closed
This was referenced Jul 3, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhanberg mhanberg mhanberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[definition] local variables
2 participants
@biletskyy @mhanberg