Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(definition): go to dependency #147

Closed
wants to merge 1 commit into from
Closed

feat(definition): go to dependency #147

wants to merge 1 commit into from

Conversation

mhanberg
Copy link
Collaborator

@mhanberg mhanberg commented Aug 9, 2023

This enables the tracers when your dependencies are compiling, which adds them to the symbol table.

TODO

  • Make sure that they do not show up in Workspace Symbols
  • see if we need/can show the progress message when the database is finishing a "batch" of updates (message can say "indexing"). It can get bogged down and the go to def won't work until it's done inserting.
  • tests
  • determine feasibility for elixir source files. they won't exist on disk, and since they aren't compiled, we won't have symbols for them, but there might be the possibility of opening the line of code in github in their web browser.

cc @dvic, feel free to take this over if you'd like!

Closes #91

@dvic
Copy link
Contributor

dvic commented Aug 9, 2023

determine feasibility for elixir source files. they won't exist on disk, and since they aren't compiled, we won't have symbols for them, but there might be the possibility of opening the line of code in github in their web browser.

If you use ASDF and build Elixir from source (i.e., use elixir ref:v1.15.4 instead of elixir 1.15.4-otp26) then the source code navigation works just fine in ElixirLS. I guess we can support this for now?

cc @dvic, feel free to take this over if you'd like!

sure :) I'll give it a go!

@mhanberg
Copy link
Collaborator Author

mhanberg commented Aug 9, 2023

ElixirLS uses the elixir sense project instead of only elixir core, which gives it other capabilities.

If we can determine the function/module using the Code.Fragment module and it's path, then should be good.

@mhanberg
Copy link
Collaborator Author

mhanberg commented Aug 9, 2023

  • make sure dependencies don't show up in Find References

@mhanberg
Copy link
Collaborator Author

Superceded by #171

@mhanberg mhanberg closed this Aug 11, 2023
@mhanberg mhanberg deleted the go-to-dep branch August 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[definition] dependency definitions
2 participants