Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt to run mix deps.get #53

Closed
mhanberg opened this issue Jun 26, 2023 · 4 comments · Fixed by #384 or #381
Closed

prompt to run mix deps.get #53

mhanberg opened this issue Jun 26, 2023 · 4 comments · Fixed by #384 or #381
Assignees
Labels
enhancement New feature or request

Comments

@mhanberg
Copy link
Collaborator

if you don't have dependencies installed, the editor should prompt you to install them and accept a yes or no.

this should avoid having to leave the editor, run mix deps.get, and open it again.

@mhanberg mhanberg added the enhancement New feature or request label Jun 26, 2023
@mhanberg mhanberg changed the title mix deps.get prompt to run mix deps.get Jun 28, 2023
@mhanberg
Copy link
Collaborator Author

@camilleryr this would be a really helpful one to tackle if you want to try it.

The gist is, when we detect a compiler error related to deps, we make a (window/showMessageRequest)[https://hexdocs.pm/gen_lsp/0.6.0/GenLSP.Requests.WindowShowMessageRequest.html] request from the server to the client to ask for a "yes/no"

I am opting to make this a prompt, because ElixirLS seemed to have many issues with auto running mix deps.get, so i'd like to try something different.

I'm not sure exactly how we should detect that deps have changed, but you'd have to figure that part out 😉.

let me know what you think!

@camilleryr
Copy link

@mhanberg - That sounds great! I was actually looking into this earlier, Ill see what I can cook up with for detecting if the deps have changed and let you know what I come up with!

@mhanberg
Copy link
Collaborator Author

awesome! thank you!

@mhanberg mhanberg assigned mhanberg and camilleryr and unassigned mhanberg Aug 15, 2023
@mhanberg
Copy link
Collaborator Author

@camilleryr any updates?

mhanberg added a commit to jjcarstens/next-ls that referenced this issue Feb 28, 2024
mhanberg added a commit to jjcarstens/next-ls that referenced this issue Feb 28, 2024
mhanberg added a commit to jjcarstens/next-ls that referenced this issue Feb 28, 2024
mhanberg added a commit to jjcarstens/next-ls that referenced this issue Feb 28, 2024
mhanberg added a commit that referenced this issue Feb 28, 2024
mhanberg added a commit that referenced this issue Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment