fix: add type to workspace symbol (#67)

this will make it easier to see if something is a function or macro. still need to add the parameters in there as well
elixir-tools · Jun 27, 2023 · 905ff62 · 905ff62
1 parent 202a906
commit 905ff62
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/lib/next_ls.ex b/lib/next_ls.ex
@@ -115,8 +115,15 @@ defmodule NextLS do
 
     symbols =
       for %SymbolTable.Symbol{} = symbol <- SymbolTable.symbols(lsp.assigns.symbol_table), filter.(symbol.name) do
+        name =
+          if symbol.type != :defstruct do
+            "#{symbol.type} #{symbol.name}"
+          else
+            "#{symbol.name}"
+          end
+
         %SymbolInformation{
-          name: to_string(symbol.name),
+          name: name,
           kind: elixir_kind_to_lsp_kind(symbol.type),
           location: %Location{
             uri: "file://#{symbol.file}",

diff --git a/test/next_ls_test.exs b/test/next_ls_test.exs
@@ -342,7 +342,7 @@ defmodule NextLSTest do
                },
                "uri" => "file://#{cwd}/lib/bar.ex"
              },
-             "name" => "foo"
+             "name" => "def foo"
            } in symbols
 
     assert %{
@@ -360,7 +360,7 @@ defmodule NextLSTest do
                },
                "uri" => "file://#{cwd}/lib/bar.ex"
              },
-             "name" => "Bar"
+             "name" => "defmodule Bar"
            } in symbols
 
     assert %{
@@ -396,7 +396,7 @@ defmodule NextLSTest do
                },
                "uri" => "file://#{cwd}/lib/code_action.ex"
              },
-             "name" => "Foo.CodeAction.NestedMod"
+             "name" => "defmodule Foo.CodeAction.NestedMod"
            } in symbols
   end
 
@@ -438,7 +438,7 @@ defmodule NextLSTest do
                  },
                  "uri" => "file://#{cwd}/lib/bar.ex"
                },
-               "name" => "foo"
+               "name" => "def foo"
              },
              %{
                "kind" => 12,
@@ -455,7 +455,7 @@ defmodule NextLSTest do
                  },
                  "uri" => "file://#{cwd}/lib/code_action.ex"
                },
-               "name" => "foo"
+               "name" => "def foo"
              }
            ] == symbols
   end