fix: only fetch most recent reference for that position

elixir-tools · Jul 31, 2023 · 00fbfbf · 00fbfbf
1 parent bff4eec
commit 00fbfbf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/next_ls/db.ex b/lib/next_ls/db.ex
@@ -174,7 +174,7 @@ defmodule NextLS.DB do
   def __query__({conn, logger}, query, args) do
     args = Enum.map(args, &cast/1)
 
-    with {:error, _e} <- :esqlite3.q(conn, query, cast(args)) do
+    with {:error, _e} <- :esqlite3.q(conn, query, args) do
       error = :esqlite3.error_info(conn).errmsg
       NextLS.Logger.error(logger, error)
       {:error, error}

diff --git a/lib/next_ls/definition.ex b/lib/next_ls/definition.ex
@@ -18,7 +18,10 @@ defmodule NextLS.Definition do
             AND refs.start_line <= ?
             AND ? <= refs.end_line
             AND refs.start_column <= ?
-            AND ? <= refs.end_column;
+            AND ? <= refs.end_column
+        ORDER BY refs.id desc
+        LIMIT 1;
+
         """,
         [file, line, line, col, col]
       )