[Finch] Change error handling, fix for response stream #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamon
pushed a commit
that referenced
this pull request
Apr 11, 2024
teamon
added a commit
that referenced
this pull request
Apr 11, 2024
* Request/Response streaming for Finch adapter * [Finch] Change error handling, fix for response stream (#573) --------- Co-authored-by: Adam Hodowany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSE introduced inconsistent error here: https://github.com/elixir-tesla/tesla/blob/tt/finch-stream/lib/tesla/adapter/finch.ex#L143
Finch adapter was always expecting Mint error.
I've looked at other adapters and seems like
{:error, :timeout}is used consistently, previous error-handling implementation would respond with{:error, "timeout"}- thus the change not to useException.message/1anymore. This is potentially a breaking change for anyone using Finch adapter.