Trim final newlines

[J3RN]

Remove all trailing newlines after the final newline in the file.

This actually does not contradict "files.insertFinalNewline" as I feared it would, as the documenation reads

When enabled, will trim all new lines after the final new line at the end of the file when saving it.

(emphasis mine)

[jayjun]

I agree with adding this to html-eex.

But I wonder if all formatting settings in elixir can be replaced by

{
  "editor.formatOnSave": true
}

[axelson]

Hmm, I think this setting would still be useful since some people may turn off format on save. Although I think it would be best to not make format on save the default until the ElixirLS formatter is improved. In particular elixir-lsp/elixir-ls#289 should be fixed, and probably elixir-lsp/elixir-ls#252 as well.

[J3RN]

formatOnSave seems like the sort of thing I would leave as opt-in. My current team does not use the Elixir formatter at all, though we might be more of an exception than a rule.

trimFinalNewlines, conversely, is a good practice for most files, Elixir and otherwise, IMO. However, it would be far out of scope for us to enforce that rule for all files 😄

[jayjun]

Cool, I agree. Looks good to me.

[J3RN]

@axelson Is this good to merge?

[axelson]

Yeah it is! Thanks! ❤️