Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate tasks to 2.0.0 syntax #71

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Conversation

dustypomerleau
Copy link
Contributor

@dustypomerleau dustypomerleau commented Apr 14, 2020

Attempting to launch the Extension Development Host window with F5 threw an error for me, because tasks.json was still using 0.1.0 syntax. Updating to 2.0.0 syntax fixed the problem for me. It's possible that locally installing the packaged extension (as described in the README) circumvents this problem, or that other contributors have been focused on ElixirLS, and don't actually develop in VS Code. In any event, I see no harm in using the new syntax 😄.

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks like a good change. Just a minor question on the details.

Comment on lines +25 to +26
"showReuseMessage": true,
"clear": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these properties listed on https://code.visualstudio.com/docs/editor/tasks-appendix is there documentation for them somewhere else?

Copy link
Contributor Author

@dustypomerleau dustypomerleau Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additions to the presentation property just customize the appearance/behavior of the terminal when running tasks.

  • showReuseMessage controls whether the terminal shows the message "Terminal will be reused by tasks, press any key to close it."
  • clear controls whether the terminal is cleared before that particular task is run.

Both of these are optional with the current configuration, because they are set to default behavior.

The full documentation on presentation is in this section of the VS Code User Guide.

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ❤️

@axelson axelson merged commit a97c6db into elixir-lsp:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants