Support HEEx and Surface files #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR along with elixir-lsp/elixir-ls#583 adds support for
HEExandSurfacetemplates. The changes allow VS Code to:.heexand.sfacefiles so recompilation is triggered when they change.heexor.sfacefiles are open (otherwise the server is only initiated when you open an elixir file).heexor.sfacefiles@lukaszsamson I still have to make some changes in ElixirSense to improve the integration. Currently, suggestions/autocomplete are not aware of the template context so they are mostly considering the whole file as elixir code which brings a poor experience. I'll try to work on that next week.
Since the changes implemented in this PR have no dependency from any of the planned changes in ElixirSense, they can be applied independently.
@chrismccord this PR also closes #193 as the syntax highlighting was already implemented in https://github.com/phoenixframework/vscode-phoenix.