Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribe Copy Debug Info command for disposal #149

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Subscribe Copy Debug Info command for disposal #149

merged 1 commit into from
Nov 6, 2020

Conversation

jayjun
Copy link
Contributor

@jayjun jayjun commented Oct 31, 2020

The Disposable returned from registering Copy Debug Info command should be subscribed to.

axelson
axelson approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! ❤️

@axelson axelson merged commit 2fc0dad into elixir-lsp:master Nov 6, 2020
@jayjun jayjun deleted the dispose branch November 7, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelson axelson axelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayjun @axelson