Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting binary number literal #133

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Correcting binary number literal #133

merged 1 commit into from
Aug 22, 2020

Conversation

wingyplus
Copy link
Contributor

  • Do not highlight "0B" prefix because it's incorrect syntax
    for Elixir.
  • Add support for underscore separator.

Fixes #129

@thanabodee-c
Correcting binary number literal
ad0f78f 
* Do not highlight "0B" prefix because it's incorrect syntax
  for Elixir.
* Add support for underscore separator.

Fixes elixir-lsp#129
axelson
axelson approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@axelson axelson merged commit 76312e7 into elixir-lsp:master Aug 22, 2020
@wingyplus wingyplus deleted the iss-129 branch August 23, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelson axelson axelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary number highlight incorrectly
3 participants
@wingyplus @axelson @thanabodee-c