Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not raise while handling exception in format_doc_arg #291

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Do not raise while handling exception in format_doc_arg #291

merged 1 commit into from
Mar 8, 2024

Conversation

aj-foster
Copy link
Contributor

Previously, an issue with the interpolation of the raised exception (Exception.blame/3 returns a tuple) caused format_doc_arg to raise an unrelated error.

@aj-foster
Do not raise while handling exception in format_doc_arg
d02fde8 
Previously, an issue with the interpolation of the raised exception caused
format_doc_arg to raise an unrelated error.
@lukaszsamson
Copy link
Collaborator

Thanks

@lukaszsamson lukaszsamson merged commit a183ca3 into elixir-lsp:master Mar 8, 2024
@aj-foster aj-foster mentioned this pull request Mar 8, 2024
Open
@aj-foster aj-foster deleted the aj/format-doc-error branch March 8, 2024 17:32
@lukaszsamson
Copy link
Collaborator

I fixed a few more cases in 33eb7ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aj-foster @lukaszsamson