Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation retrieval for module's built-in attributes #233

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

Goose97
Copy link
Contributor

@Goose97 Goose97 commented Jun 30, 2023

Closes #227

@lukaszsamson
Copy link
Collaborator

That's a good first step @Goose97 but 2 more things should be covered here.

  1. we need docs on attribute completion as well
  2. I was thinking of extending and using BuiltinAttributes module here. It has some more documented elixir attributes that are not returned by Module.reserved_attributes. We need to copy docs for those from elixir repo

@Goose97 Goose97 force-pushed the add-module-attributes-docs branch from 1288317 to b2c2608 Compare July 4, 2023 07:06
@Goose97
Copy link
Contributor Author

Goose97 commented Jul 4, 2023

I've adjusted the PR following your suggestions.

I removed struct from the buil-in list, because:

  1. It was renamed to __struct__
  2. This attribute is an implementation detail, so would it make more sense it we don't expose it?

@Goose97 Goose97 force-pushed the add-module-attributes-docs branch from b2c2608 to 0df89e1 Compare July 4, 2023 07:19
@lukaszsamson
Copy link
Collaborator

Thanks

@lukaszsamson lukaszsamson merged commit 8a55365 into elixir-lsp:master Jul 7, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return documentation on builtin attributes
2 participants