Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed logging of errors to be quieted. #165

Merged
merged 3 commits into from
Nov 6, 2022

Commits on Oct 14, 2022

  1. Allowed logging of errors to be quieted.

    While using elixir-ls, frequently, the code that's sent to the LSP
    server (and then to elixir_sense) isn't always syntactically accurate,
    and sometimes elixir_sense will fail and spam the logs. After enough
    of these spammy logs, emacs throws the error into a mini-buffer to
    alert the user to some problem, which is not particularly helpful.
    
    Emitting an error message in these circumstances is dubious, since
    there's nothing truly wrong, but I can understand that it might be
    helpful for other uses of elixir_ls. To that end, I consolidated the
    logging functions into a module and gated them with an application
    variable so that other apps can enable or disable logging at their
    discretion.
    scohen committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    0d7af20 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Moved to macros

    I was thinking about the prior implementation, and I think it would
    mess up the line and files due to it calling a function in the Log
    module. Making pass through macros surrounded by an if simplifies
    things greatly.
    scohen committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    3860f65 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Configuration menu
    Copy the full SHA
    6ae36d1 View commit details
    Browse the repository at this point in the history