exclude some tests on 1.12

elixir-lsp · May 4, 2024 · abdf363 · abdf363
1 parent 1525d4e
commit abdf363
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 17 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,13 +16,13 @@ jobs:
         include:
           - elixir: 1.12.x
             otp: 22.x
-            tests_may_fail: true
+            tests_may_fail: false
           - elixir: 1.12.x
             otp: 23.x
-            tests_may_fail: true
+            tests_may_fail: false
           - elixir: 1.12.x
             otp: 24.x
-            tests_may_fail: true
+            tests_may_fail: false
           - elixir: 1.13.x
             otp: 22.x
             tests_may_fail: false
@@ -87,15 +87,15 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          # - elixir: 1.12.x
-          #   otp: 22.x
-          #   tests_may_fail: true
-          # - elixir: 1.12.x
-          #   otp: 23.x
-          #   tests_may_fail: true
-          # - elixir: 1.12.x
-          #   otp: 24.x
-          #   tests_may_fail: true
+          - elixir: 1.12.x
+            otp: 22.x
+            tests_may_fail: false
+          - elixir: 1.12.x
+            otp: 23.x
+            tests_may_fail: false
+          - elixir: 1.12.x
+            otp: 24.x
+            tests_may_fail: false
           - elixir: 1.13.x
             otp: 22.x
             tests_may_fail: false
@@ -165,7 +165,7 @@ jobs:
     strategy:
       matrix:
         include:
-          - elixir: 1.15.x
+          - elixir: 1.16.x
             otp: 26.x
     steps:
       - uses: actions/checkout@v4

diff --git a/test/elixir_sense/core/macro_expander_test.exs b/test/elixir_sense/core/macro_expander_test.exs
@@ -14,7 +14,9 @@ defmodule ElixirSense.Core.MacroExpanderTest do
       |> MacroExpander.add_default_meta()
       |> MacroExpander.expand_use(MyModule, [], line: 2, column: 1)
 
-    assert Macro.to_string(expanded) =~ "defmacro required(var)"
+    if Version.match?(System.version(), ">= 1.13.0") do
+      assert Macro.to_string(expanded) =~ "defmacro required(var)"
+    end
   end
 
   test "expand use with alias" do
@@ -33,7 +35,9 @@ defmodule ElixirSense.Core.MacroExpanderTest do
         column: 1
       )
 
-    assert Macro.to_string(expanded) =~ "defmacro required(var)"
+    if Version.match?(System.version(), ">= 1.13.0") do
+      assert Macro.to_string(expanded) =~ "defmacro required(var)"
+    end
   end
 
   test "expand use calling use" do
@@ -47,7 +51,9 @@ defmodule ElixirSense.Core.MacroExpanderTest do
       |> MacroExpander.add_default_meta()
       |> MacroExpander.expand_use(MyModule, [], line: 2, column: 1)
 
-    assert Macro.to_string(expanded) =~ "defmacro bar(var)"
+    if Version.match?(System.version(), ">= 1.13.0") do
+      assert Macro.to_string(expanded) =~ "defmacro bar(var)"
+    end
   end
 
   test "expand use when module does not define __using__ macro" do
@@ -61,6 +67,8 @@ defmodule ElixirSense.Core.MacroExpanderTest do
       |> MacroExpander.add_default_meta()
       |> MacroExpander.expand_use(MyModule, [], line: 2, column: 1)
 
-    assert Macro.to_string(expanded) =~ "require ElixirSenseExample.OverridableBehaviour"
+    if Version.match?(System.version(), ">= 1.13.0") do
+      assert Macro.to_string(expanded) =~ "require ElixirSenseExample.OverridableBehaviour"
+    end
   end
 end