return full module name in completions

lib/elixir_sense/providers/suggestion/complete.ex

@@ -445,7 +445,8 @@ defmodule ElixirSense.Providers.Suggestion.Complete do
           {"", %{}}
         end
 
-      %{kind: :module, name: ":" <> mod, type: :erlang, desc: desc, subtype: subtype}
+      name = ":" <> mod
+      %{kind: :module, name: name, full_name: name, type: :erlang, desc: desc, subtype: subtype}
     end
   end
 
@@ -520,10 +521,17 @@ defmodule ElixirSense.Providers.Suggestion.Complete do
   end
 
   defp match_aliases(hint, env) do
-    for {alias, _mod} <- env.aliases,
+    for {alias, mod} <- env.aliases,
         [name] = Module.split(alias),
         Matcher.match?(name, hint) do
-      %{kind: :module, type: :alias, name: name, desc: {"", %{}}, subtype: nil}
+      %{
+        kind: :module,
+        type: :alias,
+        name: name,
+        full_name: inspect(mod),
+        desc: {"", %{}},
+        subtype: nil
+      }
     end
   end
 
@@ -557,7 +565,15 @@ defmodule ElixirSense.Providers.Suggestion.Complete do
     |> Enum.map(fn {name, module, required_alias?} ->
       {desc, meta} = Introspection.get_module_docs_summary(module)
       subtype = Introspection.get_module_subtype(module)
-      result = %{kind: :module, type: :elixir, name: name, desc: {desc, meta}, subtype: subtype}
+
+      result = %{
+        kind: :module,
+        type: :elixir,
+        name: name,
+        full_name: inspect(module),
+        desc: {desc, meta},
+        subtype: subtype
+      }
 
       if required_alias? do
         Map.put(result, :required_alias, module)
@@ -566,8 +582,12 @@ defmodule ElixirSense.Providers.Suggestion.Complete do
       end
     end)
     |> Enum.reject(fn
-      %{required_alias: _, subtype: :implementation} -> true
-      _ -> false
+      %{required_alias: _, subtype: :implementation} ->
+        # reject protocol implementations, there is rarely a reason to alias them
+        true
+
+      _ ->
+        false
     end)
   end
 
@@ -937,6 +957,7 @@ defmodule ElixirSense.Providers.Suggestion.Complete do
   defp to_entries(%{
          kind: :module,
          name: name,
+         full_name: full_name,
          required_alias: module,
          desc: {desc, metadata},
          subtype: subtype
@@ -945,6 +966,7 @@ defmodule ElixirSense.Providers.Suggestion.Complete do
       %{
         type: :module,
         name: name,
+        full_name: full_name,
         required_alias: module,
         subtype: subtype,
         summary: desc,
@@ -953,8 +975,23 @@ defmodule ElixirSense.Providers.Suggestion.Complete do
     ]
   end
 
-  defp to_entries(%{kind: :module, name: name, desc: {desc, metadata}, subtype: subtype}) do
-    [%{type: :module, name: name, subtype: subtype, summary: desc, metadata: metadata}]
+  defp to_entries(%{
+         kind: :module,
+         full_name: full_name,
+         name: name,
+         desc: {desc, metadata},
+         subtype: subtype
+       }) do
+    [
+      %{
+        type: :module,
+        name: name,
+        full_name: full_name,
+        subtype: subtype,
+        summary: desc,
+        metadata: metadata
+      }
+    ]
   end
 
   defp to_entries(%{kind: :variable, name: name}) do

test/elixir_sense/providers/suggestion/complete_test.exs

@@ -32,6 +32,7 @@ defmodule ElixirSense.Providers.Suggestion.CompleteTest do
     assert [
              %{
                name: ":zlib",
+               full_name: ":zlib",
                subtype: nil,
                summary: summary,
                type: :module,
@@ -64,13 +65,14 @@ defmodule ElixirSense.Providers.Suggestion.CompleteTest do
 
   test "elixir proxy" do
     list = expand('E')
-    assert list |> Enum.find(&(&1.name == "Elixir"))
+    assert list |> Enum.find(&(&1.name == "Elixir" and &1.full_name == "Elixir.Elixir"))
   end
 
   test "elixir completion" do
     assert [_ | _] = expand('En')
 
-    assert [%{name: "Enumerable", subtype: :protocol, type: :module}] = expand('Enumera')
+    assert [%{name: "Enumerable", full_name: "Enumerable", subtype: :protocol, type: :module}] =
+             expand('Enumera')
   end
 
   test "elixir module completion with @moduledoc false" do
@@ -235,8 +237,13 @@ defmodule ElixirSense.Providers.Suggestion.CompleteTest do
   end
 
   test "elixir root submodule completion" do
-    assert [%{name: "Access", summary: "Key-based access to data structures."}] =
-             expand('Elixir.Acce')
+    assert [
+             %{
+               name: "Access",
+               full_name: "Access",
+               summary: "Key-based access to data structures."
+             }
+           ] = expand('Elixir.Acce')
 
     assert [_ | _] = expand('Elixir.')
   end
@@ -245,6 +252,7 @@ defmodule ElixirSense.Providers.Suggestion.CompleteTest do
     assert [
              %{
                name: "Chars",
+               full_name: "String.Chars",
                subtype: :protocol,
                summary:
                  "The `String.Chars` protocol is responsible for\nconverting a structure to a binary (only if applicable)."
@@ -257,6 +265,7 @@ defmodule ElixirSense.Providers.Suggestion.CompleteTest do
     assert [
              %{
                name: "Chars",
+               full_name: "String.Chars",
                subtype: :protocol,
                summary:
                  "The `String.Chars` protocol is responsible for\nconverting a structure to a binary (only if applicable)."
@@ -269,6 +278,7 @@ defmodule ElixirSense.Providers.Suggestion.CompleteTest do
     assert [
              %{
                name: "Chars",
+               full_name: "String.Chars",
                subtype: :protocol,
                summary:
                  "The `String.Chars` protocol is responsible for\nconverting a structure to a binary (only if applicable)."
@@ -286,11 +296,18 @@ defmodule ElixirSense.Providers.Suggestion.CompleteTest do
 
   test "find elixir modules that require alias" do
     assert [
-             %{metadata: %{}, name: "Chars", required_alias: String.Chars},
-             %{metadata: %{}, name: "Chars", required_alias: List.Chars},
+             %{
+               metadata: %{},
+               name: "Chars",
+               full_name: "String.Chars",
+               required_alias: String.Chars
+             },
+             %{metadata: %{}, name: "Chars", full_name: "List.Chars", required_alias: List.Chars},
              %{
                metadata: %{},
                name: "CallerWithAliasesAndImports",
+               full_name:
+                 "ElixirSense.Providers.ReferencesTest.Modules.CallerWithAliasesAndImports",
                required_alias:
                  ElixirSense.Providers.ReferencesTest.Modules.CallerWithAliasesAndImports
              }
@@ -1088,9 +1105,13 @@ defmodule ElixirSense.Providers.Suggestion.CompleteTest do
       }
     }
 
-    assert [%{name: "Some", type: :module}] = expand('Som', env)
-    assert [%{name: "OtherModule", type: :module}] = expand('Some.', env)
-    assert [%{name: "MyAlias", type: :module}] = expand('MyA', env)
+    assert [%{name: "Some", full_name: "Some", type: :module}] = expand('Som', env)
+
+    assert [%{name: "OtherModule", full_name: "Some.OtherModule", type: :module}] =
+             expand('Some.', env)
+
+    assert [%{name: "MyAlias", full_name: "Some.OtherModule.Nested", type: :module}] =
+             expand('MyA', env)
   end
 
   test "alias rules" do
@@ -1626,6 +1647,7 @@ defmodule ElixirSense.Providers.Suggestion.CompleteTest do
     assert [
              %{
                name: "File",
+               full_name: "File",
                type: :module,
                metadata: %{},
                subtype: nil,

test/elixir_sense/suggestions_test.exs

@@ -297,19 +297,28 @@ defmodule ElixirSense.SuggestionsTest do
     assert list == [
              %{
                name: "ModuleWithDocFalse",
+               full_name: "ElixirSenseExample.ModuleWithDocFalse",
                subtype: nil,
                summary: "",
                type: :module,
                metadata: %{}
              },
              %{
                name: "ModuleWithDocs",
+               full_name: "ElixirSenseExample.ModuleWithDocs",
                subtype: :behaviour,
                summary: "An example module\n",
                type: :module,
                metadata: %{since: "1.2.3"}
              },
-             %{metadata: %{}, name: "ModuleWithNoDocs", subtype: nil, summary: "", type: :module}
+             %{
+               metadata: %{},
+               name: "ModuleWithNoDocs",
+               full_name: "ElixirSenseExample.ModuleWithNoDocs",
+               subtype: nil,
+               summary: "",
+               type: :module
+             }
            ]
   end
 
@@ -1805,6 +1814,7 @@ defmodule ElixirSense.SuggestionsTest do
     assert Enum.at(list, 0) == %{
              type: :module,
              name: "Elixir",
+             full_name: "Elixir.Elixir",
              subtype: nil,
              summary: "",
              metadata: %{}