Support go to definition in the experimental project #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scohen
requested changes
Feb 21, 2023
apps/language_server/lib/language_server/experimental/code_mod/location.ex
Outdated
Show resolved
Hide resolved
apps/language_server/lib/language_server/experimental/provider/handlers/goto_definition.ex
Outdated
Show resolved
Hide resolved
apps/language_server/lib/language_server/experimental/provider/handlers/goto_definition.ex
Outdated
Show resolved
Hide resolved
apps/language_server/lib/language_server/experimental/provider/handlers/goto_definition.ex
Outdated
Show resolved
Hide resolved
apps/language_server/lib/language_server/experimental/code_mod/location.ex
Outdated
Show resolved
Hide resolved
apps/language_server/test/experimental/provider/handlers/goto_definition_test.exs
Outdated
Show resolved
Hide resolved
apps/language_server/test/experimental/provider/handlers/goto_definition_test.exs
Outdated
Show resolved
Hide resolved
apps/language_server/test/experimental/provider/handlers/goto_definition_test.exs
Outdated
Show resolved
Hide resolved
apps/language_server/test/experimental/provider/handlers/goto_definition_test.exs
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Cohen <[email protected]>
scohen
reviewed
Feb 22, 2023
apps/language_server/lib/language_server/experimental/provider/handlers/goto_definition.ex
Outdated
Show resolved
Hide resolved
apps/language_server/lib/language_server/experimental/source_file/conversions.ex
Outdated
Show resolved
Hide resolved
apps/language_server/test/experimental/provider/handlers/goto_definition_test.exs
Outdated
Show resolved
Hide resolved
apps/language_server/lib/language_server/experimental/provider/handlers/goto_definition.ex
Outdated
Show resolved
Hide resolved
apps/language_server/test/experimental/provider/handlers/goto_definition_test.exs
Outdated
Show resolved
Hide resolved
apps/language_server/test/experimental/provider/handlers/goto_definition_test.exs
Outdated
Show resolved
Hide resolved
scohen
approved these changes
Mar 2, 2023
lukaszsamson
reviewed
Mar 2, 2023
apps/language_server/lib/language_server/experimental/source_file/conversions.ex
Show resolved
Hide resolved
lukaszsamson
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure of the experimental project is excellent. Thanks to @scohen for the great work. I will continue to migrate other providers in order of priority of frequency of use.
goto definition preview with nvim lspsaga
when normal:
when nil: