-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename function/variable #791
Open
timgent
wants to merge
11
commits into
elixir-lsp:master
Choose a base branch
from
timgent:rename_symbol
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jan 24, 2023
-
POC for "rename" functionality
LSPs can offer a rename capability to rename a "symbol" across a workspace. We're not there yet, but this is a starting point. In VS Code it can be used by right clicking a symbol (currently variable or call to local function) and selecting "Rename symbol". A dialog should pop up asking for a new name. Official spec: https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_rename
Configuration menu - View commit details
-
Copy full SHA for 6bd7de3 - Browse repository at this point
Copy the full SHA 6bd7de3View commit details -
Configuration menu - View commit details
-
Copy full SHA for aecdfa7 - Browse repository at this point
Copy the full SHA aecdfa7View commit details -
Simplify tests with rename_example
- Make rename_example a `.ex` file so we can later test multi-file refactors - Simplify rename_example to make it easier to follow - Extract some common patterns out in the tests
Configuration menu - View commit details
-
Copy full SHA for 27da270 - Browse repository at this point
Copy the full SHA 27da270View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cf7ab8 - Browse repository at this point
Copy the full SHA 0cf7ab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70b5bb5 - Browse repository at this point
Copy the full SHA 70b5bb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8db226c - Browse repository at this point
Copy the full SHA 8db226cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3d2b30 - Browse repository at this point
Copy the full SHA f3d2b30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73f8178 - Browse repository at this point
Copy the full SHA 73f8178View commit details -
Configuration menu - View commit details
-
Copy full SHA for b52042c - Browse repository at this point
Copy the full SHA b52042cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f18d548 - Browse repository at this point
Copy the full SHA f18d548View commit details
Commits on May 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4634203 - Browse repository at this point
Copy the full SHA 4634203View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.