Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return LSP 3.17 labelDetails on completion items #787

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

lukaszsamson
Copy link
Collaborator

@lukaszsamson lukaszsamson commented Dec 13, 2022

annotate completions that require alias insertions deprioretize alias insertion
fix crash when completing one line source file

Examples from vscode
Screenshot 2022-12-13 at 07 01 19
Screenshot 2022-12-13 at 07 01 43
Screenshot 2022-12-13 at 07 02 16

Addresses #774

annotate completions that require alias insertions
deprioretize alias insertion
fix crash when completing one line source file
@scohen
Copy link
Contributor

scohen commented Dec 13, 2022

I like the alias XXX annotation, that fixes the earlier problems.

Slight nitpick though: It's puzzling to me why typing Enum. would have EmptyError and OutOfBoundsException show up before Enum.all. Exceptions should be sorted pretty far down in the list of possible completions, but this does bring up structs, which are probably as important as functions, but shouldn't be super high on the list for this specific completion.

@lukaszsamson
Copy link
Collaborator Author

Slight nitpick though: It's puzzling to me why typing Enum. would have EmptyError and OutOfBoundsException show up before Enum.all. Exceptions should be sorted pretty far down in the list of possible completions, but this does bring up structs, which are probably as important as functions, but shouldn't be super high on the list for this specific completion.

Nice idea. It was easy to deprioretize exceptions.

Screenshot 2022-12-14 at 23 40 48

@lukaszsamson lukaszsamson merged commit 25dc8f0 into master Dec 16, 2022
@lukaszsamson lukaszsamson deleted the ls-improve-auto-alias branch December 16, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants