Fix prefixing unused variables with underscore #778
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I noticed some issues with this feature and an attempt to revert it (#775), I would like to propose a fix that hopefully makes it more usable.
Instead of adding
_
at the beginning of the line, I would replace the unused variablevar
with_var
usingString.replace/4
with the following regex:"(?<![[:alnum:]._])#{variable}(?![[:alnum:]._])"
I assume the unused variable does not have any of
.
_
as a prefix or suffix.
Also, to prevent replacing incorrectly in the cases like:
I'm not creating a quickfix if there is more than one match in the line.