Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for autocompletion of 'fn' within parentheses #768

Merged

Conversation

vanderhoop
Copy link
Contributor

@vanderhoop vanderhoop commented Nov 11, 2022

The 'autocomplete within parens' behavior wasn't working for me in vs-code, so I hopped into the repo to write a failing test, but the test passed right away (🤔) and I'm now seeing the behavior sometimes work (and sometimes not) in vs-code

  • my conclusion is that the issue is likely in the vs-code extension—or in vs-code outright—but I figured I'd submit a PR with the regression test if it's desired. Feel free to close if not!

  - so, this behavior wasn't working for me in vs-code, so I hopped into
    the repo to write a failing test, but the test passed right away (🤔)
    and I'm now seeing the behavior _sometimes_ work and sometimes not
    in vs-code
  - conclusion is that the issue is likely in the vs-code extension, but
    I figured I'd submit a PR with the regression test if it's desired
@lukaszsamson lukaszsamson merged commit 2984b66 into elixir-lsp:master Nov 13, 2022
@lukaszsamson
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants