Tracer was not being called via start_supervised #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused it not to cleanly exit before the next test, but only sometimes. Flaky tests are no fun.
scohen
commented
Oct 15, 2022
| @@ -235,13 +235,13 @@ defmodule ElixirLS.LanguageServer.ServerTest do | |||
| end | |||
|
|
|||
| setup context do | |||
| unless context[:skip_server] do | |||
| if context[:skip_server] do | |||
There was a problem hiding this comment.
note: unless with an else is flagged by credo for legibility.
There was a problem hiding this comment.
I don’t think that it’s a code smell
|
That one was irritating. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused it not to cleanly exit before the next test, but only sometimes.
Flaky tests are no fun.