Moved SourceFile path operations to SourceFile.Path module #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszsamson
reviewed
Oct 6, 2022
scohen
force-pushed
the
scohen/source-file-path-ops
branch
from
bc1d067
to
f20be94
Compare
SourceFile is doing a lot of stuff that it doesn't need to do; the path operations are a good example of code that can be better when it's extracted from the SourceFile module.
scohen
force-pushed
the
scohen/source-file-path-ops
branch
from
f20be94
to
cf8fd5a
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceFile is doing a lot of stuff that it doesn't need to do; the path operations are a good example of code that can be better when it's extracted from the SourceFile module.