Add basic code action support #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucacervello can you check on elixir 1.14? Since elixir-lang/elixir#11965 is fixed compiler should return |
scohen
added a commit
to scohen/elixir-ls
that referenced
this pull request
Nov 23, 2022
This reverts commit 9fe8ea1.
lukaszsamson
pushed a commit
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a basic code action support.
It's similar to
elixir-lswhich means we parse diagnostic messages in order to enable different code actions.I tried to add an action to prepend unused variables with
_as suggested here #140 but It's not working very well because I don't have the column of the variable.Maybe there are better actions to implement ?