fix(test runner): Use ExUnit testPaths and testPattern #500
Conversation
| end | ||
|
|
||
| defp get_test_code_lenses(state, uri, source_file, true = _enabled, false = _umbrella) do | ||
| file_path = SourceFile.path_from_uri(uri) |
There was a problem hiding this comment.
this call will fail if URI is not in file: schema (e.g. git:, untitled:). You need to rescue and return []
|
I think we could take a simpler way and only support the default |
|
Hi @lukaszsamson!
By "simpler way" I assume you mean the implementation would be simpler? While that is true, I don't feel like the current implementation is that complex (although maybe it could be extracted somewhere else to make it easier to find and work with) and I think it would be unfortunate to leave some (admittedly probably very few) users in the dust. That said, you're the maintainer and more experienced with the project so I'll remove the functionality if you really believe it's not worth it. |
That was only a suggestion. If you find it's not too costly then feel free to do it :) |
Well it's already done and I really don't think it adds too much complexity :) I'll fix your other comment and update the tests then! |
…t_runner/use_test_paths_and_pattern
|
All right, tests are updated, along with a couple bug fixes! @lukaszsamson I think this should fix the last of the issues in #438 on the elixir-ls side. |
* fix(test runner): Use ExUnit testPaths and testPattern * Handle bad URI format * Add tests for test_paths and test_pattern * Make all fixture apps unique * Rename umbrella app to match filesystem * wait for compilation after tests * wait for compilation before code lens request
First draft of a new way to identify through ExUnit's
testPathsandtestPatternparameters. For single app projects, we get the values directly from the project configuration.For umbrella apps, I went with a configuration for now. Should we decide that we want this to be seamless, I thought we could evaluate each app's
mix.exsfile and execute theproject/0function, but that would imply running client code on the server.As far as I know, these configurations are rarely changed, so while it is an inconvenience, I don't think it will affect too many people.
I'll start working on tests once I've had confirmation that we want to move forward with this.
Here's an example of what we expect these new configs to look like:
testPattern
{ "app1": "*_custom_app1_pattern.exs", "app2": "*_custom_app2_pattern.exs" }testPaths
{ "app1": ["my_app1_custom_path"], "app2": ["my_app2_custom_path"] }As of opening, this should fix the last of the issues described in #438.