-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve debugger stability #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelson
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is an impressive list of fixes ❤️
@@ -7,7 +7,7 @@ defmodule ElixirLS.Debugger.Output do | |||
are sent with sequence numbers that are unique and sequential, and includes client functions for | |||
sending these messages. | |||
""" | |||
import ElixirLS.Utils.WireProtocol, only: [send: 1] | |||
alias ElixirLS.Utils.WireProtocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 💯
lukaszsamson
added a commit
that referenced
this pull request
Apr 20, 2023
Fixes elixir-lsp/vscode-elixir-ls#322 Bug introduced in #457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces stability and reliability improvements to debugger.
:int
module crashes. Some operations crash withMatchError
when the operation results in a step out of interpreted codethread
event with reasonexited
. vscode UI is no longer stuck in paused stateOutputDevice
. The module now now more closely adheres to erlang I/O protocol (see https://erlang.org/doc/apps/stdlib/io_protocol.html). Most importantly:Fixes #452
Fixes #454
Fixes #455
Fixes #456