-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for disabling automatic builds though a config #440
add support for disabling automatic builds though a config #440
Conversation
b37f545
to
ec20c6c
Compare
Hmm, I don't think this approach will work very well since the code would never get rebuilt which means that your auto completions and go to implementation, etc. will be out of date. And if you wanted to build you'd have to go in your settings to enable Here's some potential approaches:
@lukaszsamson any other ideas or thoughts on implementing this feature? |
My understanding was that the config would start (My understanding was that people wanted to disable builds entirely). You bring up some good points with the above, I will see if I can tackle them, I am still new to the code base, so feel free to add any pointers. |
@axelson I think you covered all of the aspects in your comment.
I like that idea
It would be risky IMO. Every elixir release changes something in the build system. IIRC There were issues with race conditions/locks between mix and elixirLS in the past.
File watcher on |
@Hanspagh Thank you for this PR. Even though it wasn't merged, I'm using your branch to make my editor setup take way less CPU. ❤️ Disables a couple of features but super worth it in my opinion. |
I think we can merge it and add rebuild command later. @Hanspagh can you resolve merge conflict? |
@Hanspagh Hello, thank you for your PR, do you think it would be possible to update the branch, so it can be merged? |
should we merge? |
ec20c6c
to
ea30d2c
Compare
The merge conflicts is solved now atleast, then you can decide what wanna do with this :) |
closes #341
Adds a config check before starting a build in
trigger_build
.I was hesitant to add it to
build_enabled
since it also seems to be used bydialyzer_enabled
I tried to follow what was outlined in this comment
First PR on a language server, so any feedback is very welcome.