use ASDF_DIR variable to support Homebrew installs #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `launch.sh` script will check for asdf in my home directory. As I am a Homebrew user, my asdf got installed to `/usr/local/opt/asdf`. For `launch.sh` to be able to detect it I've modified it for the use of `ASDF_DIR` if available and fall-back to the current behaviour if that's not set. asdf will set the [`ASDF_DIR` (see upstream source)][1] variable when it initializes, so this seems to be a reliable way to detect all sorts of customized asdf installations. [1]: https://github.com/asdf-vm/asdf/blob/master/asdf.sh#L14
lukaszsamson
approved these changes
Dec 2, 2020
|
@lukaszsamson Test failure seems to be unrelated, could you trigger a re-run? |
|
Awesome CI passes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
launch.shscript will check for asdf in my home directory.As I am a Homebrew user, my asdf got installed to
/usr/local/opt/asdf.For
launch.shto be able to detect it I've modified it for the use ofASDF_DIRif available and fall-back to the current behaviour if that's not set.asdf will set the
ASDF_DIR(see upstream source) variable when it initializes, so this seems to be a reliable way to detect all sorts of customized asdf installations.