Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #413
While trying to build current master on Erlang/OTP 22 Elixir 1.9.1 I encountered an error:
I debugged it and seen that it is because
mix_task_archive_deps
tries to package all dependencies except itself. Butstream_data
is a test-only dependency, so it crashes. Adding StreamData to applications ignored during packaging fixes the issue.I thought about adding a more complex solution that automatically checks for test dependencies, but I saw that in one of the issues there is discussion if
elixir_ls
should usemix_task_archive_deps
at all #115 . I personally believe it shouldn't hence the quick fix.