Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementations provider #415

Merged
merged 18 commits into from
Nov 27, 2020
Merged

Conversation

lukaszsamson
Copy link
Collaborator

@lukaszsamson lukaszsamson commented Nov 25, 2020

It's ready now. I had to revert a few changes as they break formatter tests

@lukaszsamson lukaszsamson marked this pull request as ready for review November 26, 2020 10:01
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes ❤️

@lukaszsamson
Copy link
Collaborator Author

Looking into test failures

@axelson
Copy link
Member

axelson commented Nov 26, 2020

👍 after the test failures are figured out we can merge this

fix tests on elixir < 1.11
@lukaszsamson
Copy link
Collaborator Author

For future reference the tests failed because on elixir < 1.11 the fixture modules were not loaded and somehow the are not a part of any application. There is a function :code.all_available/0 but it is otp >= 23

@axelson
Copy link
Member

axelson commented Nov 27, 2020

Here are some screenshots showing off this change:

Peek definition:
PeekDefinition

Peek implementation:
PeekImplementations

@axelson axelson merged commit 434f6bc into elixir-lsp:master Nov 27, 2020
@axelson
Copy link
Member

axelson commented Nov 27, 2020

Also peek implementations to find implementations of a protocol:

PeekImplementationsProtocol

And peek implementations to find implementations of a behaviour:

PeekImplementationBehaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants