-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementations provider #415
Conversation
…nce elixir 1.7 and we require 1.8
extract location related code to a new module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes ❤️
Looking into test failures |
👍 after the test failures are figured out we can merge this |
fix tests on elixir < 1.11
For future reference the tests failed because on elixir < 1.11 the fixture modules were not loaded and somehow the are not a part of any application. There is a function |
It's ready now. I had to revert a few changes as they break formatter tests