Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not start :debugger and :dialyzer apps to avoid depending on :wx #388

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Do not start :debugger and :dialyzer apps to avoid depending on :wx #388

merged 1 commit into from
Oct 15, 2020

Conversation

lukaszsamson
Copy link
Collaborator

Fixes #387

@lukaszsamson lukaszsamson merged commit eb8c927 into elixir-lsp:master Oct 15, 2020
@NobbZ
Copy link
Member

NobbZ commented Oct 16, 2020

After this change, do the dialyzer features like the type-lens on a function definition or annotating the dialyzer warnings still work?

@lukaszsamson
Copy link
Collaborator Author

After this change, do the dialyzer features like the type-lens on a function definition or annotating the dialyzer warnings still work?

Yes, these apps were added to extra_applications recently in 2fbb023#diff-7c2ccf97621462ad5ef8c0259130041734a7424c826f12ced3ae87cc7bdcc423 just to silence warnings on elixir 1.11 and make dialyzer pass

axelson added a commit that referenced this pull request Nov 8, 2020
@axelson
Update changelog for #388 and vscode #148 + #149
7418065
@lukaszsamson lukaszsamson deleted the ls-dont-start-wx branch November 21, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server crashing for MatchError about :wx and wx.app (no such file or directory)
2 participants
@lukaszsamson @NobbZ