feat: exclude modules by wildcard name #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this PR I'd like to introduce the possibility for modules to be excluded without knowing their full name.
Example:
```
{
"type": "mix_task",
"name": "mix phx.server",
"request": "launch",
"task": "phx.server",
"projectDir": "${workspaceRoot}",
"excludeModules": [
":phoenix",
"Phoenix",
"Phoenix.*"
]
}
```
This helped me to use the debugging feature of the vscode-elixir-ls extension. Without this feature I was unable to collect all the modules names that need to be excluded.
lukaszsamson
reviewed
Sep 9, 2020
| regex_pattern = | ||
| wildcard_pattern | ||
| |> prefix_module_name() | ||
| |> String.replace(".", ~s(\.)) |
lukaszsamson
reviewed
Sep 9, 2020
| :int.interpretable(module) == true and !:code.is_sticky(module) and module != __MODULE__ and | ||
| module not in exclude_modules | ||
| module_name not in exclude_module_names and | ||
| not Enum.any?(exclude_module_names, &module_matches_wildcard(module_name, &1)) |
There was a problem hiding this comment.
compute wildcards patterns once before instead of once for every module
|
@lukaszsamson I've integrated your suggestions, maybe take another look if this is good to go? |
|
@lukaszsamson Hey, did you have the chance to take another look? |
|
Sorry, I missed the notification earlier. Looks good now, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I'd like to introduce the possibility for modules to be excluded without knowing their full name.
Example:
This helped me to use the debugging feature of the vscode-elixir-ls extension which kept failing for our team. Without this feature I was unable/unwilling to collect all the modules names that need to be excluded. The only approach, to gather the required module names, seemed to be trial and error based, which combined with the debuggers starting times felt disproportionate.