Update Hover to return MarkupContent #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszsamson
approved these changes
Aug 14, 2020
|
Nice catch! |
axelson
added a commit
that referenced
this pull request
Aug 17, 2020
axelson
added a commit
to axelson/ls_proxy
that referenced
this pull request
Sep 3, 2020
Matches elixir-ls PR: elixir-lsp/elixir-ls#342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋 In my research into an issue with Emacs'
lsp-ui, I discovered that the "Hover" response from ElixirLS was returning the deprecated MarkedString type (technically just a string, which is a valid MarkedString and thus compliant with the spec).The conversion from MarkedString to the non-deprecated MarkupContent type was pretty painless, so I made the change.