Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple eval support #339

Merged
merged 6 commits into from
Aug 12, 2020
Merged

Conversation

sofakingworld
Copy link
Contributor

@axelson @JakeBecker would you please accept this PR?

It changes behaviour in VSCode plugin from
image

to
image

@lukaszsamson
Copy link
Collaborator

It looks good @sofakingworld . A small improvement and we can merge it.
FYI @JakeBecker stepped down from maintaining this project

@JakeBecker
Copy link
Collaborator

I'm not actively maintaining ElixirLS, but this is very cool! Good stuff!

@sofakingworld
Copy link
Contributor Author

sofakingworld commented Aug 6, 2020

btw debug console is working too! 🥳

without feature 👇🏻

image

How soon will be updated VSCode extension ? Wanna use it officially))

@sofakingworld
Copy link
Contributor Author

Sorry for commit after approve, but i add some good feature.

Added access to variables in evaluation mode

image

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it's really exciting! And thanks for the tests too! ❤️

@axelson axelson merged commit 21c93f7 into elixir-lsp:master Aug 12, 2020
axelson added a commit that referenced this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants