WIP: Configuration file support #338
Conversation
Add a user configuration file that is read on startup. Change the server settings to always be fully fleshed out. So the ElixirLS.LanguageServer.Server state `settings` always has all the settings (and as atoms) instead of being an empty map by default. This consolidates the default setting logic into the new `ConfigParser` module instead of being strewn about the Server. TODO: - [ ] Fix tests (I'm getting a strange error with the tests that I cannot figure out.) - [ ] Read a configuratioon file from the repository Note: Editor configuration always overrides the configuration file, and the VSCode extension always sends in the full configuration. This means that the configuration file is not currently useable with the VSCode extension. This will probably have to be modified in the VSCode extension because I think it is important for the extension to have the final control of the server settings.
| alias ElixirLS.Utils.ConfigParser | ||
| alias ElixirLS.LanguageServer.JsonRpc | ||
|
|
||
| # Can we change this to load also from the workspace root? Note: might need multiple passes for that to work |
There was a problem hiding this comment.
Need to remove this comment before merging
| |> String.split(["\n", "\r", "\r\n"], trim: true) | ||
| |> Enum.map(&String.trim/1) | ||
| # Ignore json comments | ||
| |> Enum.reject(&String.starts_with?(&1, "#")) |
There was a problem hiding this comment.
vscode jsonc (JSON with comments) supports JS style comments only (// and /**/), see https://code.visualstudio.com/docs/languages/json#_json-with-comments
https://github.com/Microsoft/node-jsonc-parser
There was a problem hiding this comment.
haha, good catch. I've obviously haven't been doing very much js development recently. However since we're not using a full processor I don't think it's feasible to support multi line comments.
There was a problem hiding this comment.
I agree. A simple full line comment support is good enough.
| @@ -0,0 +1,7 @@ | |||
| # This is the configuration file for ElixirLS | |||
There was a problem hiding this comment.
Comment should be // as @lukaszsamson comment above.
| @@ -0,0 +1,7 @@ | |||
| # This is the configuration file for ElixirLS | |||
| { | |||
| # Disable dialyzer | |||
There was a problem hiding this comment.
This one should be // also.
|
@axelson how far is this from being done? |
|
@lukaszsamson Hmmm, I think it was fairly close at the time, but I think it's pretty out of date now so I don't know how much work would be required to bring it up to date. I also probably won't be able to dedicate time to it in the near future. |
Add a user configuration file that is read on startup.
Change the server settings to always be fully fleshed out. So the
ElixirLS.LanguageServer.Server state
settingsalways has all thesettings (and as atoms) instead of being an empty map by default. This
consolidates the default setting logic into the new
ConfigParsermodule instead of being strewn about the Server.
TODO:
Note: Editor configuration always overrides the configuration file, and
the VSCode extension always sends in the full configuration. This means
that the configuration file is not currently useable with the VSCode
extension. This will probably have to be modified in the VSCode
extension because I think it is important for the extension to have the
final control of the server settings.
Fixes #60