Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to create gitignore when project dir is not set #306

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Do not try to create gitignore when project dir is not set #306

merged 1 commit into from
Jun 25, 2020

Conversation

lukaszsamson
Copy link
Collaborator

Fixes #304

axelson
axelson approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ❤️

@axelson axelson merged commit e7f7c88 into elixir-lsp:master Jun 25, 2020
axelson added a commit that referenced this pull request Jun 28, 2020
@axelson
Update changelog for #306 and vscode #112
a02fc78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelson axelson axelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on gitignore cration when project dir is not set
2 participants
@lukaszsamson @axelson