Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call DocumentSymbols.symbols/3 for .ex and .exs files #262

Merged
merged 1 commit into from
May 26, 2020
Merged

Only call DocumentSymbols.symbols/3 for .ex and .exs files #262

merged 1 commit into from
May 26, 2020

Conversation

msaraiva
Copy link
Collaborator

This PR fixes the following problem:

If the user has the outline panel enabled and opens a .eex or .leex file, the call to DocumentSymbols.symbols/3 fails since those files are not valid Elixir syntax.

Message:

[Error - 9:14:39 PM] Request textDocument/documentSymbol failed.
  Message: [DocumentSymbols] Compilation error while parsing source file
  Code: -32000

axelson
axelson approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@axelson axelson merged commit a8bdf93 into elixir-lsp:master May 26, 2020
@msaraiva msaraiva deleted the fix-document-symbol branch May 26, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelson axelson axelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msaraiva @axelson