Fix Formatting.format returns character float number #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingyplus
changed the title
axelson
requested changes
May 18, 2020
| @@ -81,7 +81,7 @@ defmodule ElixirLS.LanguageServer.Providers.Formatting do | |||
| else | |||
| # LSP contentChanges positions are based on UTF-16 string representation | |||
| # https://microsoft.github.io/language-server-protocol/specification#textDocuments | |||
| {line, col + byte_size(:unicode.characters_to_binary(char, :utf8, :utf16)) / 2} | |||
| {line, col + trunc(byte_size(:unicode.characters_to_binary(char, :utf8, :utf16)) / 2)} | |||
There was a problem hiding this comment.
Can you change this to use Kernel.div/2 instead?
|
@axelson your suggestion was addressed. CI fail because of dialyzer test. I think this is not related with this changes. |
This bug happens because of use `/ 2` in advance_pos which is convert into floating number. Fixes by using `trunc/1`. And add test to ensure line and character always integer. Fixes elixir-lsp#249
|
@x-ji commit was squash and ci are all green. |
axelson
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug happens because of use
/ 2in advance_pos which is convertinto floating number. Fixes by using
trunc/1. And add test to ensureline and character always integer.
Fixes #249