DocumentSymbols provider handles compilation errors gracefully #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than throwing an exception (which causes the spawned process to crash) the DocumentSymbols provider will now simply return an error. This is beneficial because this is very much an expected error and thus it is confusing to show the exception in the logs. Possibly there are also performance benefits to this as well. Ideally the DocumentSymbols provider could still return valid symbols in this case, but that is currently infeasible.
The easiest way of making it more error tolerant is by using elixir_sense Parser (elixir-lsp/elixir_sense#87). We'd need to refactor it though to separate parsing from metadata building. |
|
Ah, I forgot about that issue. I agree that would be a good improvement. Tracking in #187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than throwing an exception (which causes the spawned process to crash) the DocumentSymbols provider will now simply return an error.
This is beneficial because this is very much an expected error and thus it is confusing to show the exception in the logs. Possibly there are also performance benefits to this as well.
Ideally the DocumentSymbols provider could still return valid symbols in this case, but that is currently infeasible.