Add support for deprecated and completion tags in complete provider #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update elixir sense
axelson
requested changes
Apr 4, 2020
| items = | ||
| Enum.reject(items, fn item -> | ||
| !snippets_supported && snippet?(item) | ||
| {:snippets_supported, false} in options and snippet?(item) |
There was a problem hiding this comment.
Suggested change
| {:snippets_supported, false} in options and snippet?(item) | |
| snippets_supported = Keyword.get(options, :snippets_supported, false) | |
| !snippets_supported && snippet?(item) |
I think using functions from the keyword module will make this logic easier to understand, especially to understand the default being used.
| insert_text_format(:snippet) | ||
| else | ||
| insert_text_format(:plain_text) | ||
| end | ||
| } | ||
|
|
||
| # deprecated as of Language Server Protocol Specification - 3.15 | ||
| json = | ||
| if {:deprecated_supported, true} in options do |
| json | ||
| end | ||
|
|
||
| tag_supported = options |> Keyword.fetch!(:tag_supported) |
There was a problem hiding this comment.
Can we change this keyword to be tags_supported? (another option would be just tag_support, but I prefer the first).
axelson
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update elixir sense to bring EEP48 metadata support in docs