Add workspaceSymbol capability #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszsamson
force-pushed
the
ls-add-workspace-symbols
branch
from
48d701c
to
95283e3
Compare
|
Thanks for this. Will take a closer look soon. |
lukaszsamson
force-pushed
the
ls-add-workspace-symbols
branch
2 times, most recently
from
a703ec1
to
b82d658
Compare
axelson
requested changes
Feb 10, 2020
apps/language_server/lib/language_server/providers/workspace_symbols.ex
Outdated
Show resolved
Hide resolved
apps/language_server/lib/language_server/providers/workspace_symbols.ex
Outdated
Show resolved
Hide resolved
apps/language_server/lib/language_server/providers/workspace_symbols.ex
Outdated
Show resolved
Hide resolved
apps/language_server/lib/language_server/providers/workspace_symbols.ex
Outdated
Show resolved
Hide resolved
…ymbols.ex Co-Authored-By: Jason Axelson <[email protected]>
…ymbols.ex Co-Authored-By: Jason Axelson <[email protected]>
lukaszsamson
force-pushed
the
ls-add-workspace-symbols
branch
from
c6c8d6a
to
2e71ddb
Compare
axelson
reviewed
Feb 13, 2020
axelson
reviewed
Feb 13, 2020
axelson
approved these changes
Feb 13, 2020
axelson
added a commit
that referenced
this pull request
May 29, 2020
* WorkspaceSymbols index after successful build Previously WorkspaceSymbols depended on a side-effect of running Dialyzer: #110 (comment) Now that the Build step loads all modules (added in #227) we need to change the WorkspaceSymbols index to be rebuilt after a successful compile. * Fix tests Allow WorkspaceSymbol to have it's own instance of the GenServer for the test by being parameterized by the server's registered name * Give Server some more time to respond This is probably necessary now because workspace symbols is running earlier * Bump up the timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds workspaceSymbol capability.
It's now possible to search and navigate to modules, functions, types and callbacks. Both Elixir and erlang modules are supported.
WorkspaceSymbols server maintains an index of symbols and listens for notifications about build events and source changes. Initial indexing is rather slow (it takes about 25s on my machine) but following updates are fast.
This provider uses fuzzy logic for matching symbols so exact queries are not needed.
To make results more relevant prefixes are utilised:
ffor functions,tfor types andcfor callbacks. Module queries don't need a prefix. Function/type/callback queries can add a filter by arity with/suffix.Addresses #66