Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Helix Installation Instructions to README.md #1026

Closed
wants to merge 1 commit into from

Conversation

samusz
Copy link

@samusz samusz commented Nov 15, 2023

As discussed in #993. (Sorry for the delay in creating this PR)

comment-token = "#"
indent = {tab-width = 2, unit = " "}
language-server = {command = "elixir-ls"}
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some example config, basing on https://elixirforum.com/t/helix-editor-for-elixir-development/54964/24?u=lukaszsamson it's done like that

config = { elixirLS.dialyzerEnabled = false }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll test it first and modify the PR once that's done.

diagnostic-severity = "Hint"
comment-token = "#"
indent = {tab-width = 2, unit = " "}
language-server = {command = "elixir-ls"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add debug adapter as well. Judging from https://helix-editor.com/news/release-22-03-highlights/ it's supported

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't have time to get this done now. Hope to get to it soon.

@Wijnand
Copy link

Wijnand commented Nov 21, 2023

This seems to be the old lsp config format. Since the latest release this format was changed.

@lukaszsamson
Copy link
Collaborator

Ping

@lukaszsamson lukaszsamson added the help wanted Extra attention is needed label Dec 27, 2023
@dawkrish
Copy link
Contributor

I recently made a PR here, it may help
#1079

@samusz
Copy link
Author

samusz commented Apr 24, 2024

Since #1079 is merged, this PR can be closed.

@samusz samusz closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants