Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger crash on invalid function breakpoint #900

Closed
lukaszsamson opened this issue Jun 3, 2023 · 0 comments · Fixed by #939
Closed

Debugger crash on invalid function breakpoint #900

lukaszsamson opened this issue Jun 3, 2023 · 0 comments · Fixed by #939

Comments

@lukaszsamson
Copy link
Collaborator

Terminating: an exception was raised:
** (MatchError) no match of right hand side value: {:error, :function_not_found}
(elixir_ls_debugger 0.14.6) lib/debugger/server.ex:339: anonymous fn/3 in ElixirLS.Debugger.Server.handle_request/2
(stdlib 4.3.1) maps.erl:411: :maps.fold_1/3
(elixir_ls_debugger 0.14.6) lib/debugger/server.ex:329: ElixirLS.Debugger.Server.handle_request/2
(elixir_ls_debugger 0.14.6) lib/debugger/server.ex:115: ElixirLS.Debugger.Server.handle_cast/2
(stdlib 4.3.1) gen_server.erl:1123: :gen_server.try_dispatch/4
(stdlib 4.3.1) gen_server.erl:1200: :gen_server.handle_msg/6
(stdlib 4.3.1) proc_lib.erl:240: :proc_lib.init_p_do_apply/3
lukaszsamson added a commit that referenced this issue Jul 11, 2023
@lukaszsamson
Handle errors in setting breakpoints
5c1182b 
Disallow setting breakpoints in Inspect protocol implementations
Disallow setting breakpoints in builtin protocols and JasonV.Encoder protocol
Fixes #900
Fixes #903
Fixes #942
@lukaszsamson lukaszsamson mentioned this issue Jul 11, 2023
Merged
lukaszsamson added a commit that referenced this issue Jul 11, 2023
@lukaszsamson
Handle cases when one line belongs to many modules in debugger (#939)
7546fb1 
* break in all protocol implementations

* test unsetting implementation breakpoint

* add test

* implement fallback to runtime modules inspection

* more tests and logs

* cache module_info of interpreted modules

call to module_info may deadlock when stopped on a breakpoint
Fixes #940

* format

* Handle errors in setting breakpoints

Disallow setting breakpoints in Inspect protocol implementations
Disallow setting breakpoints in builtin protocols and JasonV.Encoder protocol
Fixes #900
Fixes #903
Fixes #942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle cases when one line belongs to many modules in debugger elixir-lsp/elixir-ls
1 participant
@lukaszsamson