Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAP 1.51 changes how execution control requests should behave #669

Closed
lukaszsamson opened this issue Jan 31, 2022 · 0 comments · Fixed by #678
Closed

DAP 1.51 changes how execution control requests should behave #669

lukaszsamson opened this issue Jan 31, 2022 · 0 comments · Fixed by #678

Comments

@lukaszsamson
Copy link
Collaborator

  • continue, next, stepIn, stepOut, stepBack, reverseContinue should by default resume all threads (we resume only a single one)
  • we should not resume all threads only if the server supports supportsSingleThreadExecutionRequests (we do but not signal it) and the client sends singleThread: true

https://microsoft.github.io/debug-adapter-protocol/changelog
https://code.visualstudio.com/updates/v1_63#_clarifications-and-improvements-for-the-execution-control-requests
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Continue
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Next
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_StepIn
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_StepOut
lukaszsamson added a commit that referenced this issue Feb 19, 2022
@lukaszsamson
make continue, next, stepIn, stepout requests conform to DAP 1.51
6eca209 
Fixes #669
reworks fixes for #455
@lukaszsamson lukaszsamson mentioned this issue Feb 19, 2022
Merged
lukaszsamson added a commit that referenced this issue Feb 19, 2022
@lukaszsamson
Make debugger conform to DAP 1.51 continue/stepin/stepout/stepover (#678
ea250e2 
)

* remove not supported SetExceptionBreakpoints request handler

Clients should only call this request if the capability ‘exceptionBreakpointFilters’ returns one or more filters.
No way to implement it via :int module

* implement function breakpoints

* test erlang breakpoints

* fix small memory leak when unsetting last breakpoint in file

* add more breakpoint tests

* make tests more synchronous

* add function breakpoints tests

* interpret modules

* extract and test mfa parsing

* run formatter

* Update readme

* cleanup

* extract and test erlang binding processing

fix some isses when var is usend more than 10 times
add explicite ordering by variable instance
discard underscored variables

* breakpoint conditions support added

do not warn when setting already set breakpoint

* update readme

* log when expression crashes

* add support for conditional function breakpoints

* update readme

* add support for breakpoint hit condition

* readme updated

* implement log message

* readme updated

* add support for terminateThreads request

* add support for pause

* make continue, next, stepIn, stepout requests conform to DAP 1.51

Fixes #669
reworks fixes for #455

* cleanup :int workaround

* tests wip

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make debugger conform to DAP 1.51 continue/stepin/stepout/stepover elixir-lsp/elixir-ls
1 participant
@lukaszsamson