Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default for fetch dependencies should be "off" #626

Closed
marcandre opened this issue Nov 15, 2021 · 1 comment · Fixed by #633
Closed

Default for fetch dependencies should be "off" #626

marcandre opened this issue Nov 15, 2021 · 1 comment · Fixed by #633

Comments

@marcandre
Copy link

Automatic fetching of the dependencies in the background is problematic for many people (e.g. here) and may be even more problematic with the improved semantic recompilation of upcoming Elixir 1.13, as I explain in this issue.

It would be wise to turn this setting off by default, at the very least for new users.
@marcandre marcandre mentioned this issue Nov 15, 2021
Closed
@axelson
Copy link
Member

axelson commented Nov 18, 2021

Hi @marcandre! Thanks for the report! This is something that I've been thinking about recently. I agree that we should turn the default to off.

axelson added a commit to axelson/elixir-ls that referenced this issue Dec 4, 2021
@axelson
Default fetchDeps to false
473c2c1 
There were already race conditions (if the user runs `mix deps.get` at
the same time) and Elixir 1.13 semantic recompilation makes it worse.

Fixes elixir-lsp#626
@axelson axelson mentioned this issue Dec 4, 2021
Merged
axelson added a commit that referenced this issue Dec 4, 2021
@axelson
Default fetchDeps to false (#633)
60ef904 
There were already race conditions (if the user runs `mix deps.get` at
the same time) and Elixir 1.13 semantic recompilation makes it worse.

Fixes #626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default fetchDeps to false axelson/elixir-ls
2 participants
@axelson @marcandre