Skip to content

Commit

Permalink
do not run failing tests on old elixir versions
Browse files Browse the repository at this point in the history
  • Loading branch information
@lukaszsamson
lukaszsamson committed Feb 7, 2024
1 parent d4f7e71 commit f70c9cd
Show file tree
Hide file tree
Showing 2 changed files with 84 additions and 58 deletions.
82 changes: 52 additions & 30 deletions apps/language_server/test/ast_utils_test.exs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,28 @@ defmodule ElixirLS.LanguageServer.AstUtilsTest do
assert get_range(":abc") == range(0, 0, 0, 4)
end

test "quoted atom string" do
assert get_range(":\"abc\"") == range(0, 0, 0, 6)
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "quoted atom string" do
assert get_range(":\"abc\"") == range(0, 0, 0, 6)
end
end

test "quoted atom charlist" do
assert get_range(":'abc'") == range(0, 0, 0, 6)
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "quoted atom charlist" do
assert get_range(":'abc'") == range(0, 0, 0, 6)
end
end

test "quoted atom string interpolated" do
assert get_range(":\"ab\#{inspect(self())}c\"") == range(0, 0, 0, 24)
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "quoted atom string interpolated" do
assert get_range(":\"ab\#{inspect(self())}c\"") == range(0, 0, 0, 24)
end
end

test "quoted atom charlist interpolated" do
assert get_range(":'ab\#{inspect(self())}c'") == range(0, 0, 0, 24)
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "quoted atom charlist interpolated" do
assert get_range(":'ab\#{inspect(self())}c'") == range(0, 0, 0, 24)
end
end

test "string" do
Expand All @@ -80,32 +88,42 @@ defmodule ElixirLS.LanguageServer.AstUtilsTest do
assert get_range("\"\"\"\nabc\n\"\"\"") == range(0, 0, 2, 3)
end

test "string heredoc with indentation" do
assert get_range("\"\"\"\n abc\n \"\"\"") == range(0, 0, 2, 5)
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "string heredoc with indentation" do
assert get_range("\"\"\"\n abc\n \"\"\"") == range(0, 0, 2, 5)
end
end

test "charlist heredoc" do
assert get_range("'''\nabc\n'''") == range(0, 0, 2, 3)
end

test "charlist heredoc with indentation" do
assert get_range("'''\n abc\n '''") == range(0, 0, 2, 5)
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "charlist heredoc with indentation" do
assert get_range("'''\n abc\n '''") == range(0, 0, 2, 5)
end
end

test "string interpolated" do
assert get_range("\"abc \#{inspect(a)} sd\"") == range(0, 0, 0, 22)
end

test "charlist interpolated" do
assert get_range("'abc \#{inspect(a)} sd'") == range(0, 0, 0, 22)
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "charlist interpolated" do
assert get_range("'abc \#{inspect(a)} sd'") == range(0, 0, 0, 22)
end
end

test "string heredoc interpolated" do
assert get_range("\"\"\"\nab\#{inspect(a)}c\n\"\"\"") == range(0, 0, 2, 3)
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "string heredoc interpolated" do
assert get_range("\"\"\"\nab\#{inspect(a)}c\n\"\"\"") == range(0, 0, 2, 3)
end
end

test "charlist heredoc interpolated" do
assert get_range("'''\nab\#{inspect(a)}c\n'''") == range(0, 0, 2, 3)
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "charlist heredoc interpolated" do
assert get_range("'''\nab\#{inspect(a)}c\n'''") == range(0, 0, 2, 3)
end
end

test "sigil" do
Expand Down Expand Up @@ -343,13 +361,15 @@ defmodule ElixirLS.LanguageServer.AstUtilsTest do
assert get_range(text) == range(0, 0, 1, 14)
end

test "remote call pipe no parens" do
text = """
123
|> Some.fun1
"""
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "remote call pipe no parens" do
text = """
123
|> Some.fun1
"""

assert get_range(text) == range(0, 0, 1, 12)
assert get_range(text) == range(0, 0, 1, 12)
end
end

test "local call pipe" do
Expand Down Expand Up @@ -445,13 +465,15 @@ defmodule ElixirLS.LanguageServer.AstUtilsTest do
assert get_range(text) == range(0, 0, 2, 3)
end

test "def short notation" do
test = ~S"""
defp name(%Config{} = config),
do: :"#{__MODULE__}_#{config.node_id}_#{config.channel_unique_id}"
"""
if Version.match?(System.version(), ">= 1.13.0-dev") do
test "def short notation" do
test = ~S"""
defp name(%Config{} = config),
do: :"#{__MODULE__}_#{config.node_id}_#{config.channel_unique_id}"
"""

assert get_range(test) == range(0, 0, 1, 68)
assert get_range(test) == range(0, 0, 1, 68)
end
end
end
end
60 changes: 32 additions & 28 deletions apps/language_server/test/providers/selection_ranges_test.exs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -228,21 +228,23 @@ defmodule ElixirLS.LanguageServer.Providers.SelectionRangesTest do
assert_range(ranges, range(1, 0, 2, 4))
end

test "left from do" do
text = """
do
1
24
if Version.match?(System.version(), ">= 1.14.0-dev") do
test "left from do" do
text = """
do
1
24
end
"""

ranges = get_ranges(text, 0, 0)
# full range
assert_range(ranges, range(0, 0, 4, 0))
# outside do-end
assert_range(ranges, range(0, 0, 3, 3))
# do
assert_range(ranges, range(0, 0, 0, 2))
end
"""

ranges = get_ranges(text, 0, 0)
# full range
assert_range(ranges, range(0, 0, 4, 0))
# outside do-end
assert_range(ranges, range(0, 0, 3, 3))
# do
assert_range(ranges, range(0, 0, 0, 2))
end

test "right from do" do
Expand All @@ -260,21 +262,23 @@ defmodule ElixirLS.LanguageServer.Providers.SelectionRangesTest do
assert_range(ranges, range(0, 0, 3, 3))
end

test "left from end" do
text = """
do
1
24
if Version.match?(System.version(), ">= 1.14.0-dev") do
test "left from end" do
text = """
do
1
24
end
"""

ranges = get_ranges(text, 3, 0)
# full range
assert_range(ranges, range(0, 0, 4, 0))
# outside do-end
assert_range(ranges, range(0, 0, 3, 3))
# end
assert_range(ranges, range(3, 0, 3, 3))
end
"""

ranges = get_ranges(text, 3, 0)
# full range
assert_range(ranges, range(0, 0, 4, 0))
# outside do-end
assert_range(ranges, range(0, 0, 3, 3))
# end
assert_range(ranges, range(3, 0, 3, 3))
end

test "right from end" do
Expand Down

0 comments on commit f70c9cd

Please sign in to comment.